feat: Synchronize relation between contacts #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (2)
Unchanged files (6)
Total files change +1020B +0.05% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
zatteo
reviewed
Nov 15, 2024
zatteo
reviewed
Nov 15, 2024
zatteo
reviewed
Nov 15, 2024
| } catch (error) { | ||
| log.error('Error updating related contact', error) | ||
| } | ||
| } |
There was a problem hiding this comment.
So createRelatedContact and updateRelatedContact are equal ? Maybe you can use only one function called upsertRelatedContact. But it's your choice, sometimes it's good to have the different path explicit.
There was a problem hiding this comment.
In fact, I prefer to separate the different actions.
(Initially, I was also thinking of using another CC helper in this function).
There was a problem hiding this comment.
I've updated the code because it wasn't working when removing a “relationTypes”.
This is a problem on the cozy-client side, so I'm updating “manually” to avoid delaying the feature.
See issue cozy/cozy-client#1560
zatteo
reviewed
Nov 15, 2024
|
Some questions, but very pleasant to read. Looks a lot like clean code. |
Following on from the work started on this PR #985. The aim is to synchronize relationship changes between the contacts concerned.
Merkur39
force-pushed
the
feat/ver-1093
branch
from
0e679b7 to
bea68e3
Compare
zatteo
approved these changes
Nov 18, 2024
zatteo
added a commit
to cozy/cozy-keys-browser
that referenced
this pull request
Nov 18, 2024
I had to start with a special case for "me" update, because in Cozy Contacts, relations were stored only in the contact who created the relation. So when "me" was updated, a relation of me could have been deleted, and it was impossible to know which one easily, so it was impossible to know if the contact should be removed from the extension. With cozy/cozy-contacts#1020, relations are propagated to the target contact. So we will get a realtime event and we will be able to check if the contact must be displayed or not without any special case. And I can also check that a contact is related to me directly by checking its relationships now.
zatteo
added a commit
to cozy/cozy-keys-browser
that referenced
this pull request
Nov 18, 2024
I had to start with a special case for "me" update, because in Cozy Contacts, relations were stored only in the contact who created the relation. So when "me" was updated, a relation of me could have been deleted, and it was impossible to know which one easily, so it was impossible to know if the contact should be removed from the extension. With cozy/cozy-contacts#1020, relations are propagated to the target contact. So we will get a realtime event and we will be able to check if the contact must be displayed or not without any special case. And I can also check that a contact is related to me directly by checking its relationships now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the work started on this PR #985.
The aim is to synchronize relationship changes between the contacts concerned.